Address CI Action EOL #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnate
commented
Jan 31, 2025
| # Only upload if a previous step fails | ||
| if: failure() | ||
| with: | ||
| name: rspec_results | ||
| name: rspec_results_${{ matrix.simulation-type }} |
There was a problem hiding this comment.
This is the key change required by the upload-artifact version bump
| @@ -8,5 +8,5 @@ | |||
|
|
|||
| - [ ] Unit tests have been added or updated | |||
| - [ ] All ci tests pass (green) | |||
| - [ ] An [issue](https://github.com/urbanopt/urbanopt-cli/issues) has been created (which will be used for the changelog) | |||
| - [ ] This PR has been labeled appropriately (which will be used for the changelog) | |||
There was a problem hiding this comment.
Different reminder for the current technique of building our changelog
kflemin
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #[issue number here]
Pull Request Description
Upload-artifact v3 reached its end of life on 2025-01-30. To continue saving CI output from failed runs (for a week, as before), we are required to use v4 of that Action, and update our naming technique.
And then, since I was messing around in the
.githubfolder, I updated our templates. Easy to revert if we don't like those changes.Checklist (Delete lines that don't apply)